Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simpleSelect to use ["object", "path", "as", "array"] syntax for tagKeyFilter #257

Open
adrw opened this Issue Apr 2, 2019 · 1 comment

Comments

1 participant
@adrw
Copy link
Member

commented Apr 2, 2019

Currently can only really filter object single layer deep using simpleSelect(subState, tag, "data").

Similar to lodash get() and set(), we should be able to pass in an array which is a longer than one level path into the subState.tag

simpleSelect(subState, tag, ["data", "nested", "object"])

This would simplify data retrieval thoroughly and reduce the need for the currently not working tagKeyFunction alternate parameter.

simpleSelect(props.subState, “domain.data” | [“domain”, “data”, tag], { opts })

@adrw adrw self-assigned this Apr 2, 2019

@adrw adrw added this to To do in adrw via automation Apr 2, 2019

@adrw adrw added this to Low priority in 0.2.0 Apr 4, 2019

@adrw

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

Simplify simpleSelect and add tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.