Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Emotion from Styled-Components #282

Open
adrw opened this issue May 6, 2019 · 1 comment

Comments

1 participant
@adrw
Copy link
Member

commented May 6, 2019

Much easier testing, faster, smaller, more flexible API.

@adrw adrw added this to Needs triage in 0.2.0 via automation May 6, 2019

@adrw adrw moved this from Needs triage to High priority in 0.2.0 May 6, 2019

adrw added a commit to adrw/misk-web that referenced this issue May 6, 2019

@adrw adrw moved this from High priority to In Progress in 0.2.0 May 6, 2019

@adrw

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

  • [Core] is migrated.
  • [Dev] Has it removed from externals (so it will add to any tab's package size if they use Styled-Components.
  • [Dev] has will leave all existing support in tooling.
  • [Common] moving forward won't include @emotion packages either in vendors so users can use either library.
  • Both will remain in [Common] package.json dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.