New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] 0.1.3-15 [CLOSES #136] Full SimpleNetwork Library #139

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
2 participants
@adrw
Copy link
Member

adrw commented Feb 7, 2019

  • [CLOSES #136] Full HTTP methods coverage in SimpleNetwork library in @misk/core
  • Made generic handling function for methods that don't have a data parameter (DELETE, HEAD, GET)
  • Bump dependencies in tabs/palette to prepare for new SimpleNetwork demo component
  • Change dispatch function names to new idiom of {state domain}{action name} ie. dispatchSimpleNetwork.simpleNetworkGet
  • Add breaking change rename of simpleNetwork functions to Changelog

@adrw adrw force-pushed the adrw:adrw/20190206.SimpleNetwork branch from f94b446 to dc7a820 Feb 7, 2019

@wesleyk

This comment has been minimized.

Copy link
Collaborator

wesleyk commented Feb 7, 2019

As a metapoint: in the future could you split out logical code changes from the various dependency bumps / release changes in distinct commits? Makes it a bit hard for me to distinguish what I should pay attention to.

@wesleyk

wesleyk approved these changes Feb 7, 2019

Copy link
Collaborator

wesleyk left a comment

LG. Are there any unit tests we could add for this network library?

tag: string,
url: string,
requestConfig?: AxiosRequestConfig
) => IAction<SIMPLENETWORK.DELETE, ISimpleNetworkPayload>
failure: (error: any) => IAction<SIMPLENETWORK.FAILURE, ISimpleNetworkPayload>
get: (
simpleNetworkFailure: (

This comment has been minimized.

@wesleyk

wesleyk Feb 7, 2019

Collaborator

interesting, why are success and failure a part of these definitions?

This comment has been minimized.

@adrw

adrw Feb 7, 2019

Author Member

By convention, they seem to be included in the dispatcher object since they are a Redux action type. That being said, they are functions that are to my knowledge only every internally called so I did look into separating them for this release. I chose against it initially because of the significant refactoring and merge typing that would be required but it may make sense so that the exported dispatcher that developers use only holds APIs that they should use.

This comment has been minimized.

@wesleyk

wesleyk Feb 7, 2019

Collaborator

What is a redux action type :-). And how do those relate to the standard http actions?

@adrw

This comment has been minimized.

Copy link
Member Author

adrw commented Feb 7, 2019

As a metapoint: in the future could you split out logical code changes from the various dependency bumps / release changes in distinct commits? Makes it a bit hard for me to distinguish what I should pay attention to.

Good idea, I'll start to do that and will update the releasing doc accordingly

@adrw

This comment has been minimized.

Copy link
Member Author

adrw commented Feb 7, 2019

LG. Are there any unit tests we could add for this network library?

Yes I'm looking into a library that will let us mock out and unit test Redux flows like this. The actual network part probably doesn't need to be extensively tested because it's entirely provided by Axios.

@adrw adrw force-pushed the adrw:adrw/20190206.SimpleNetwork branch from dc7a820 to 235c931 Feb 7, 2019

@adrw adrw changed the title [RELEASE] 0.1.3-12 [CLOSES #136] Full SimpleNetwork Library [RELEASE] 0.1.3-15 [CLOSES #136] Full SimpleNetwork Library Feb 7, 2019

[RELEASE] 0.1.3-15 [CLOSES #136] Full SimpleNetwork Library
* [CLOSES #136] Full HTTP methods coverage in SimpleNetwork library in `@misk/core`
* Made generic handling function for methods that don't have a data parameter (DELETE, HEAD, GET)
* Bump dependencies in `tabs/palette` to prepare for new SimpleNetwork demo component
* Change dispatch function names to new idiom of `{state domain}{action name}` ie. `dispatchSimpleNetwork.simpleNetworkGet`
* Add breaking change rename of simpleNetwork functions to Changelog

@adrw adrw force-pushed the adrw:adrw/20190206.SimpleNetwork branch from 3ffb004 to c31ee22 Feb 7, 2019

@adrw adrw merged commit acc5176 into square:master Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment