Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modified example/data as simpler web project in example/gradle #232

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@adrw
Copy link
Member

adrw commented Mar 1, 2019

  • To test misk-web-plugin can build web projects, a basic one inside each integration test directory is required
  • Previously used an old version of palette which was difficult to maintain given its active development
  • Now using the examples/data project is much simpler and easier to maintain
Use modified example/data as simpler web project in example/gradle
* To test `misk-web-plugin` can build web projects, a basic one inside each integration test directory is required
* Previously used an old version of `palette` which was difficult to maintain given its active development
* Now using the examples/data project is much simpler and easier to maintain

@adrw adrw force-pushed the adrw:adrw/20190301.SimpleExampleGradleWeb branch from 9142c75 to 298ec3d Mar 1, 2019

@adrw

This comment has been minimized.

Copy link
Member Author

adrw commented Mar 1, 2019

Will rework so the test projects are actual tabs and have the miskTab.json that signifies being a tab.

@adrw adrw closed this Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.