Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove examples/gradle #234

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@adrw
Copy link
Member

adrw commented Mar 1, 2019

  • Will replace with JUnit tests for misk-web-plugin when the sourceSet functionality is added
  • Since web builds are no longer done with the plugin, these integration test directories are no longer useful

@adrw adrw force-pushed the adrw:adrw/20190301.SimpleExampleGradleWeb branch 2 times, most recently from d811046 to 869a42d Mar 1, 2019

Remove examples/gradle
* Will replace with JUnit tests for `misk-web-plugin` when the `sourceSet` functionality is added
* Since web builds are no longer done with the plugin, these integration test directories are no longer useful

@adrw adrw force-pushed the adrw:adrw/20190301.SimpleExampleGradleWeb branch from b631b1d to aa15f89 Mar 1, 2019

@adrw adrw changed the title Use simplified palette tab as web project in example/gradle/* tests Remove examples/gradle Mar 1, 2019

@wesleyk

wesleyk approved these changes Mar 1, 2019

@adrw

This comment has been minimized.

Copy link
Member Author

adrw commented Mar 1, 2019

Merged with #235

@adrw adrw closed this Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.