Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @misk/test to allow React snapshots #277

Merged
merged 1 commit into from Apr 16, 2019
Merged

Fix @misk/test to allow React snapshots #277

merged 1 commit into from Apr 16, 2019

Conversation

adrw
Copy link
Collaborator

@adrw adrw commented Apr 16, 2019

  • Fixes error of ReferenceError: document is not defined where jest could not find an HTML document where the rendered component could be found
  • Runs tests inside of a JS DOM environment where HTML can be rendered and tested

* Fixes error of `ReferenceError: document is not defined` where jest could not find an HTML document where the rendered component could be found
* Runs tests inside of a JS DOM environment where HTML can be rendered and tested
@adrw adrw changed the title Add --env=jsdom to test script to allow React snapshots Fix @misk/test to allow React snapshots Apr 16, 2019
@adrw adrw merged commit 854ded8 into cashapp:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants