Modify RedisConfig and use JedisPool #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyk
reviewed
Feb 3, 2019
hamdanjaveed
force-pushed
the
hamdan-redis-config-fix-jedis-pool
branch
from
54f55d5
to
8e04778
Compare
ryanhall07
approved these changes
Feb 6, 2019
| data class RedisReplicationGroupConfig( | ||
| val writer_endpoint: RedisNodeConfig, | ||
| val reader_endpoint: RedisNodeConfig, | ||
| val redis_auth_password: String |
There was a problem hiding this comment.
I wonder if this should be a Secret. while it's not strictly necessary now because it's a single value, I would assume in the future Secret would allow us to redact the value instead of fuzzy matching on fields named password
There was a problem hiding this comment.
I think a Secret makes sense here, I'll keep it in mind
wesleyk
reviewed
Feb 6, 2019
wesleyk
approved these changes
Feb 6, 2019
RedisConfig updated to include a writer and reader endpoint. We also use JedisPool instead of single Jedis instances to ensure thread safety.
hamdanjaveed
force-pushed
the
hamdan-redis-config-fix-jedis-pool
branch
from
8e04778
to
12b251b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RedisConfig updated to include a writer and reader endpoint. We also use JedisPool
instead of single Jedis instances to ensure thread safety.