New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out hibernate query limits into dependency to speed up ReflectionQueryFactoryTest #763

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
4 participants
@wesleyk
Copy link
Collaborator

wesleyk commented Feb 7, 2019

No description provided.

@wesleyk wesleyk requested review from swankjesse , hamdanjaveed , ryanhall07 and adrw Feb 7, 2019

@wesleyk wesleyk force-pushed the wesley-test branch from 004c939 to 1b572c2 Feb 7, 2019

@adrw

adrw approved these changes Feb 7, 2019

transacter.transaction { session ->
for (i in 3101..10100) {
for (i in 32..41) {

This comment has been minimized.

@adrw

adrw Feb 7, 2019

Member

Were any of these tests (that have been significantly reduced in quantity) the stress testing ones that had been mentioned in discussions? If so, should we have a way to still run them periodically (say daily) but not on every build / PR?

This comment has been minimized.

@wesleyk

wesleyk Feb 7, 2019

Author Collaborator

The intention of these aren't to stress test, they're to see that the various logs are outputted

This comment has been minimized.

@wesleyk

wesleyk Feb 7, 2019

Author Collaborator

(I wouldn't consider 10K to necessarily be "stress testing" anyways)

@wesleyk wesleyk force-pushed the wesley-test branch from 1b572c2 to 664c113 Feb 7, 2019

@wesleyk wesleyk merged commit dda6a64 into master Feb 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment