Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Actions Tab 0.1 #809

Merged
merged 2 commits into from Mar 2, 2019

Conversation

Projects
None yet
2 participants
@adrw
Copy link
Member

adrw commented Mar 2, 2019

  • Responsive, interactive UI for introspecting bound WebActions
  • Shows following metadata
    • Name
    • Path
    • Function
    • HTTP Method
    • Access Annotation
    • Request -> Response Content Types
    • Application Interceptors
    • Network Interceptors

ezgif com-video-to-gif

screen shot 2019-03-01 at 8 10 24 pm

@adrw adrw force-pushed the adrw:adrw/20190301.WebActionsTab1 branch 3 times, most recently from ef10e02 to a909620 Mar 2, 2019

@wesleyk

wesleyk approved these changes Mar 2, 2019

</span>
)

enum HttpMethod {

This comment has been minimized.

@wesleyk

wesleyk Mar 2, 2019

Collaborator

seems a bit strange that we have to re-define http methods. Is this nowhere else?

This comment has been minimized.

@adrw

adrw Mar 2, 2019

Author Member

Agreed, it should be upstreamed to @misk/core, couldn't find it at first look in any of our dependency libraries that we could use out of the box.

functionAnnotations.filter(
a =>
!(
a.includes("RequestContentType") ||

This comment has been minimized.

@wesleyk

wesleyk Mar 2, 2019

Collaborator

what's the significance of these?

This comment has been minimized.

@adrw

adrw Mar 2, 2019

Author Member

It filters out annotations that contain information that will already be displayed with dedicated panels (ie. don't need to show the AccessAnnotation because there's an Access box).

This comment has been minimized.

@wesleyk

wesleyk Mar 2, 2019

Collaborator

ah gotcha. I think we'd probably want to filter this out server side if we think clients will find this not useful compared to other information provided by the API. Not a blocker for now!

This comment has been minimized.

@adrw

adrw Mar 2, 2019

Author Member

Sounds good! Definitely should upstream to the WebAction any filters / manipulations once we figure out what we'll need in the final UI 👍

adrw added some commits Mar 2, 2019

Web Actions Tab 0.1
* Responsive, interactive UI for introspecting bound WebActions
* Shows following metadata
  * Name
  * Path
  * Function
  * HTTP Method
  * Access Annotation
  * Request -> Response Content Types
  * Application Interceptors
  * Network Interceptors

@adrw adrw force-pushed the adrw:adrw/20190301.WebActionsTab1 branch from 7685133 to b9a064f Mar 2, 2019

@adrw adrw merged commit 8ebbc2b into square:master Mar 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.