Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Actions Tab 0.1.1 #817

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@adrw
Copy link
Member

adrw commented Mar 5, 2019

  • Preparation for filtering in release 0.2
  • Use http-method-enum library instead of our own enum
  • Move all filtering and client side processing to single lodash chain function vs. within each component
  • Use generic tooltip / menu-item wrap components to reduce boilerplate
  • Use <Collapse> to better show list of Application Interceptors or Network Interceptors (should solve null error found in staging)
  • Use action.name as primary heading with pathPattern as a tag
  • Sort on action.name then on pathPattern
  • Merge webactions that have the same pathPattern and only differ on HTTP Method (ie. all StaticResourceActions have @Get and @Post methods but identical authentication and interceptors)

screen shot 2019-03-05 at 4 44 52 pm

(the list shows up after clicking on Network Interceptors

@adrw adrw force-pushed the adrw:adrw/20190304.WebActions4 branch 2 times, most recently from 234ac4e to b58673f Mar 5, 2019

@wesleyk

wesleyk approved these changes Mar 5, 2019

@adrw adrw force-pushed the adrw:adrw/20190304.WebActions4 branch 2 times, most recently from 1d4f69b to 50ba9cf Mar 5, 2019

@adrw adrw changed the title Web Actions Tab 0.2.1 Web Actions Tab 0.2.0-1 Mar 5, 2019

Web Actions Tab 0.1.1
* Preparation for filtering in release 0.2
* Use `http-method-enum` library instead of our own enum
* Move all filtering and client side processing to single lodash `chain` function vs. within each component
* Use generic tooltip / menu-item wrap components to reduce boilerplate
* Use `<Collapse>` to better show list of Application Interceptors or Network Interceptors (should solve `null` error found in staging)
* Use `action.name` as primary heading with `pathPattern` as a tag
* Sort on `action.name` then on `pathPattern`
* Merge webactions that have the same `pathPattern` and only differ on HTTP Method (ie. all StaticResourceActions have `@get` and `@post` methods but identical authentication and interceptors)

@adrw adrw force-pushed the adrw:adrw/20190304.WebActions4 branch from 50ba9cf to 4f60413 Mar 6, 2019

@adrw adrw changed the title Web Actions Tab 0.2.0-1 Web Actions Tab 0.1.1 Mar 6, 2019

@adrw adrw merged commit 11800ab into square:master Mar 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.