Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include allowed services/roles in WebActionMetadata API #819

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@wesleyk
Copy link
Collaborator

wesleyk commented Mar 6, 2019

No description provided.

@wesleyk wesleyk requested review from swankjesse and adrw Mar 6, 2019

@adrw

adrw approved these changes Mar 6, 2019


@Inject lateinit var webActionMetadataAction: WebActionMetadataAction

@Test fun webActionMetadata() {

This comment has been minimized.

@adrw

adrw Mar 6, 2019

Member

Great tests!

import javax.inject.Inject

// Common module for web action-related tests to use to use that bind up some sample web actions
class TestWebActionModule : KAbstractModule() {

This comment has been minimized.

@adrw

adrw Mar 6, 2019

Member

Good call to refactor this out to it's own class.

@@ -70,6 +74,8 @@ internal fun WebActionMetadata(
pathPattern = pathPattern.toString(),
applicationInterceptors = applicationInterceptors.map { it::class.qualifiedName.toString() },
networkInterceptors = networkInterceptors.map { it::class.qualifiedName.toString() },
dispatchMechanism = dispatchMechanism
dispatchMechanism = dispatchMechanism,
allowedServices = allowedServices,

This comment has been minimized.

@adrw

adrw Mar 6, 2019

Member

🎉

@adrw adrw merged commit da14036 into master Mar 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.