Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigAdminAction reads the full loaded Config #821

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@mightyguava
Copy link
Collaborator

mightyguava commented Mar 6, 2019

Bind the app config as a Config, inject into ConfigAdminAction, and serialize it to YAML.

@mightyguava mightyguava requested a review from adrw Mar 6, 2019

@adrw

adrw approved these changes Mar 6, 2019

Copy link
Member

adrw left a comment

Great fix!

@mightyguava mightyguava force-pushed the yunchi/config-admin branch from 4fc11a0 to 03ead28 Mar 6, 2019

@mightyguava mightyguava merged commit 46bc6cd into master Mar 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mightyguava mightyguava deleted the yunchi/config-admin branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.