Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Actions Tab 0.1.3 - 0.1.4 #823

Merged
merged 2 commits into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@adrw
Copy link
Member

adrw commented Mar 6, 2019

  • Move client side processing of metadata to Redux so it is not render blocking
  • Skeleton Loading Component instead of using <Spinner/>

@adrw adrw force-pushed the adrw:adrw/20190306.WebActions6 branch 2 times, most recently from 24ffd40 to 1579bb0 Mar 6, 2019

@wesleyk

wesleyk approved these changes Mar 6, 2019

@@ -288,81 +256,64 @@ export const FilterWebActions = (props: IState & IDispatchProps) => {
</div>
)
}
const SkeletonText = () => (
<span className={Classes.SKELETON}>{"Lorem ipsum"}</span>

This comment has been minimized.

@wesleyk

wesleyk Mar 6, 2019

Collaborator

hmm will this ever show up to devs?

This comment has been minimized.

@adrw

adrw Mar 6, 2019

Author Member

If computation takes too long, usually may flash prior to being filled in with the real data. Similar to the Skeleton table we already use in SampleTableComponent in Misk-Web/Palette

https://square.github.io/misk-web/examples/tabs/palette/demo/

This comment has been minimized.

@wesleyk

wesleyk Mar 6, 2019

Collaborator

why not put no txt?

This comment has been minimized.

@adrw

adrw Mar 6, 2019

Author Member

A bit unintuitive at first glance but allows a way to mock the final UI when the data has loaded: https://blueprintjs.com/docs/#core/components/skeleton

return (
<div>
<WebActions metadata={metadata} {...props} />
{/* <FilterWebActions {...props} /> */}

This comment has been minimized.

@wesleyk

wesleyk Mar 6, 2019

Collaborator

this is confusing, is this commented out?

This comment has been minimized.

@adrw

adrw Mar 6, 2019

Author Member

Yes commenting with JSX is a bit confusing.

This comment has been minimized.

@wesleyk

wesleyk Mar 6, 2019

Collaborator

so this is a comment, why are we leaving this here?

This comment has been minimized.

@adrw

adrw Mar 6, 2019

Author Member

Will remove 👍

@adrw adrw force-pushed the adrw:adrw/20190306.WebActions6 branch from 1579bb0 to d9a7114 Mar 6, 2019

.sortBy(["name", "pathPattern"])
.value()
// TODO(adrw) build index of keyspace for filterable fields
// const index = chain(metadata).value()

This comment has been minimized.

@wesleyk

wesleyk Mar 6, 2019

Collaborator

same comment about not committing commented out code like this

Web Actions Tab 0.1.3 Async Client Computation
* Move client side processing of metadata to Redux so it is not render blocking

@adrw adrw force-pushed the adrw:adrw/20190306.WebActions6 branch from d9a7114 to e044fa5 Mar 6, 2019

@adrw adrw changed the title Web Actions Tab 0.1.3 Async Client Computation Web Actions Tab 0.1.3 - 0.1.4 Mar 6, 2019

@adrw adrw force-pushed the adrw:adrw/20190306.WebActions6 branch from 08b24a0 to a15dfa3 Mar 6, 2019

@adrw adrw force-pushed the adrw:adrw/20190306.WebActions6 branch from a15dfa3 to b3bd0bf Mar 6, 2019

@adrw adrw merged commit 05a4422 into square:master Mar 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.