Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Actions Tab: Trigger Inline Requests #826

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@adrw
Copy link
Member

adrw commented Mar 7, 2019

ezgif-4-742d119b66da

<br />
<SkeletonWebActions />
<br />
<SkeletonWebActions />

This comment has been minimized.

@hamdanjaveed

hamdanjaveed Mar 7, 2019

Collaborator

Are these webaction stubs? Is this saying that in the case when there are no webactions for a service, we'll see 5 stubbed web actions? If thats the behaviour maybe some text saying "No web actions" would suffice?

This comment has been minimized.

@adrw

adrw Mar 7, 2019

Author Member

These are Blueprint Skeletons that are equivalent in purpose to a loading spinner. If the Web Actions endpoint hasn't completed yet, then this will show up to pre-write the UI. Once the data is available, it just fills in. If there are no bound Web Actions then the screen would be empty (though this won't be the case since all containers must provide readiness, liveness, and status endpoints).

This comment has been minimized.

@hamdanjaveed

hamdanjaveed Mar 7, 2019

Collaborator

Ah got it

@hamdanjaveed

This comment has been minimized.

Copy link
Collaborator

hamdanjaveed commented Mar 7, 2019

Some comments briefly explaining what the major components are would be helpful (would help with connecting the coded representation to the DOM element that it's describing).

@adrw adrw force-pushed the adrw:adrw/20190306.WebActions8 branch from 15ee004 to 9af74f6 Mar 7, 2019

@adrw adrw force-pushed the adrw:adrw/20190306.WebActions8 branch from 9af74f6 to f538111 Mar 7, 2019

@adrw adrw merged commit 46b7171 into square:master Mar 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
`${tag}::${props.action.pathPattern}::URL`
)}
value={
simpleSelect(

This comment has been minimized.

@wesleyk

wesleyk Mar 7, 2019

Collaborator

pretty long conditional here, is it easy to split these out into their own vars?

This comment has been minimized.

@adrw

adrw Mar 7, 2019

Author Member

Fixed in #827

@wesleyk

This comment has been minimized.

Copy link
Collaborator

wesleyk commented Mar 7, 2019

very cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.