Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Actions Tab: Fix All/None Roles/Services bug #830

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
3 participants
@adrw
Copy link
Member

adrw commented Mar 8, 2019

  • Unauthenticated annotation wasn't correctly determining "All" or "None" for the Services and Roles metadata
Web Actions Tab: Fix All/None Roles/Services bug
* `Unauthenticated` annotation wasn't correctly determining "All" or "None" for the Services and Roles metadata

@adrw adrw merged commit c115d6e into square:master Mar 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -159,7 +159,7 @@ function* handleMetadata() {
)
)
const emptyAllowedArrayValue =
authFunctionAnnotations.length > 1 &&
authFunctionAnnotations.length > 0 &&
authFunctionAnnotations[0].includes("Unauthenticated")

This comment has been minimized.

@wesleyk

wesleyk Mar 11, 2019

Collaborator

above we only filter authFunctionAnnotations to include "Access" or "authz", would this ever be true then?

This comment has been minimized.

@adrw

adrw Mar 11, 2019

Author Member

I'm not sure if we have a strict one Access or authz annotation per web action, if it is enforced as strictly one then we can restructure that processing so it assumes there will only ever be one match.

This comment has been minimized.

@wesleyk

wesleyk Mar 11, 2019

Collaborator

let's sync up offline about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.