Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Actions Tab: Remove Tooltip from MetadataCollapse #833

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
2 participants
@adrw
Copy link
Member

adrw commented Mar 8, 2019

  • Confusing interaction with a redundant tooltip on a Metadata item which when clicked reveals a Collapse component

@adrw adrw force-pushed the adrw:adrw/20190308.WebActions13 branch from 2b698f1 to 0c60cdb Mar 8, 2019

return (
<MenuItem
label={props.label}
text={<Tooltip>{props.content}</Tooltip>}

This comment has been minimized.

@hamdanjaveed

hamdanjaveed Mar 8, 2019

Collaborator

Probably misunderstanding but do we want the Tooltip tag here?

This comment has been minimized.

@adrw

adrw Mar 8, 2019

Author Member

An empty one provides identical padding and margin of the element.

Web Actions Tab: Remove Tooltip from MetadataCollapse
* Confusing interaction with a redundant tooltip on a Metadata item which when clicked reveals a Collapse component

@adrw adrw force-pushed the adrw:adrw/20190308.WebActions13 branch from 0c60cdb to e91083f Mar 8, 2019

@adrw adrw merged commit e414106 into square:master Mar 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.