Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Actions Tab: Basic Filtering #836

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
2 participants
@adrw
Copy link
Member

adrw commented Mar 8, 2019

Screen Shot 2019-03-08 at 6 30 41 PM

@adrw adrw force-pushed the adrw:adrw/20190308.WebActions15 branch from 9d4d96f to b84e389 Mar 11, 2019

nonAccessOrTypeFunctionAnnotations
}
})
.groupBy(groupByWebActionHash)
.groupBy("hash")

This comment has been minimized.

@wesleyk

wesleyk Mar 11, 2019

Collaborator

this is pretty magical, is there something more deterministic to use here?

This comment has been minimized.

@adrw

adrw Mar 11, 2019

Author Member

The groupByWebActionHash function previously referenced now saves the value in a key in the object called "hash". Maybe a different named key would seem less magical.

This comment has been minimized.

@wesleyk

wesleyk Mar 11, 2019

Collaborator

we're relying on the fact that the key is "hash". Can we name it something more relevant and extract that to not a magic string?

</div>
)
} else {
// Displays mock of 5 Web Action cards which fill in when data is available
return (
<div>
<SkeletonWebActions />
<SkeletonWebActions {...props} />

This comment has been minimized.

@wesleyk

wesleyk Mar 11, 2019

Collaborator

why do the mocks need this props reference?

This comment has been minimized.

@adrw

adrw Mar 11, 2019

Author Member

Initially had put in so the new filter form would be in the mock but realized I did it wrong so going to fix it and push.

@@ -43,6 +44,15 @@ export interface IWebActionInternal {
returnType: string
}

export const WebActionInternal: { [key: string]: string } = {

This comment has been minimized.

@wesleyk

wesleyk Mar 11, 2019

Collaborator

small comment explaining what this is?

@adrw adrw force-pushed the adrw:adrw/20190308.WebActions15 branch 4 times, most recently from b5d04f0 to 25d513d Mar 11, 2019

@adrw adrw force-pushed the adrw:adrw/20190308.WebActions15 branch from 25d513d to ea00151 Mar 12, 2019

@adrw adrw merged commit c764ca4 into square:master Mar 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.