Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update_version to events #935

Merged
merged 1 commit into from Apr 18, 2019

Conversation

Projects
None yet
2 participants
@qelper
Copy link
Collaborator

commented Apr 18, 2019

No description provided.

/**
* Events often represent a stream of state changes or entity updates; the update_version
* can be used to indicate the version of the updated entity or state machine at the time
* the event was generated. Not all events will have this populated, therefore optional.

This comment has been minimized.

Copy link
@ryanhall07

ryanhall07 Apr 18, 2019

Collaborator

we should make it clear that not setting this field is considered deprecated and all new events should have this field. eventually it will be required.

This comment has been minimized.

Copy link
@qelper

qelper Apr 18, 2019

Author Collaborator

update the comment to reflect that

@qelper qelper force-pushed the alihussain_apr1819_update_version branch from 23deff3 to 18f7b67 Apr 18, 2019

Ali Hussain

@qelper qelper force-pushed the alihussain_apr1819_update_version branch from 18f7b67 to 6b9dbd9 Apr 18, 2019

@qelper qelper merged commit 739db16 into master Apr 18, 2019

0 of 2 checks passed

ci/circleci: java CircleCI is running your tests
Details
ci/circleci: node CircleCI is running your tests
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.