Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zookeeper-testing module #976

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
2 participants
@ryanhall07
Copy link
Collaborator

commented May 8, 2019

and various changes to suppport using misk-zookeeper outside of misk

@ryanhall07 ryanhall07 requested review from nbroyles, wesleyk and mightyguava May 8, 2019

@wesleyk

wesleyk approved these changes May 8, 2019

dependencies {
compile dep.curatorFramework
compile dep.zookeeper
compile dep.docker

This comment has been minimized.

Copy link
@wesleyk

wesleyk May 8, 2019

Collaborator

/nit extra space

@@ -57,7 +59,8 @@ class ZkTestModule(
}

companion object {
private val sharedZookeeper = EmbeddedZookeeper(zkPortKey)
private val sharedZookeeper = EmbeddedZookeeper(
zkPortKey)

This comment has been minimized.

Copy link
@wesleyk

wesleyk May 8, 2019

Collaborator

/nit one line

This comment has been minimized.

Copy link
@ryanhall07

ryanhall07 May 8, 2019

Author Collaborator

weird. intellij did this during the refactor. bad intellij.

Add zookeeper-testing module
and various changes to suppport using misk-zookeeper outside of misk

@ryanhall07 ryanhall07 force-pushed the rhall-zookeeper-testing branch from d959545 to 07354e0 May 8, 2019

@ryanhall07 ryanhall07 merged commit 75d658a into master May 8, 2019

2 checks passed

ci/circleci: java Your tests passed on CircleCI!
Details
ci/circleci: node Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.