Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate tunneling proxies that close the connection after an auth challenge. #2467

Merged
merged 1 commit into from Apr 8, 2016

Conversation

@dave-r12
Copy link
Collaborator

dave-r12 commented Apr 7, 2016

A fix for #2426. This was mainly a rejiggering of the existing connection code.


// The proxy decided to close the connection after an auth challenge. We need to create a new
// connection, but this time with the auth credentials.
closeQuietly(rawSocket);

This comment has been minimized.

Copy link
@swankjesse

swankjesse Apr 8, 2016

Member

nit: also set rawSocket to null?

This comment has been minimized.

Copy link
@dave-r12

dave-r12 Apr 8, 2016

Author Collaborator

Yes, done.

@swankjesse

This comment has been minimized.

Copy link
Member

swankjesse commented Apr 8, 2016

LGTM

This is brilliant. Very nice.

@dave-r12 dave-r12 force-pushed the dr-Apr072016-tunnel-proxy-close branch from a7a9c73 to 03a840d Apr 8, 2016
@swankjesse swankjesse merged commit e712faa into master Apr 8, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@axel3rd

This comment has been minimized.

Copy link

axel3rd commented Apr 13, 2016

@dave-r12 / @swankjesse : Many thanks to you guys 😆

@dave-r12 dave-r12 deleted the dr-Apr072016-tunnel-proxy-close branch Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.