New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added OkHttpClient.setSpdyAddress to bypass npn negotiation #402

Closed
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@takke

takke commented Jan 5, 2014

skip npn negotiation to specify some addresses of the server which supports spdy protocol obviously.

it's possible to use spdy for some architectures not supports npn like android 2.2 to 4.0.

thanks.

@swankjesse

This comment has been minimized.

Show comment
Hide comment
@swankjesse

swankjesse Jan 5, 2014

Member

Thanks for the code! But I don't think we want this behavior in OkHttp. In general we want to work the same way that web browsers work, and this isn't how browsers work!

And even if we were going to allow clients to force a specific transport, there are problems:

  • spdy/3's days are numbered in OkHttp. The entire industry is moving to HTTP/2 and I'd like to delete OkHttp's support for spdy/3 in a year or two. What happens to this code when we do that?
  • spdy/3's days are numbered in your web server. It'll eventually migrate to HTTP/2, but it won't be able to if you're shipping client code that assumes spdy/3 without negotiation.
Member

swankjesse commented Jan 5, 2014

Thanks for the code! But I don't think we want this behavior in OkHttp. In general we want to work the same way that web browsers work, and this isn't how browsers work!

And even if we were going to allow clients to force a specific transport, there are problems:

  • spdy/3's days are numbered in OkHttp. The entire industry is moving to HTTP/2 and I'd like to delete OkHttp's support for spdy/3 in a year or two. What happens to this code when we do that?
  • spdy/3's days are numbered in your web server. It'll eventually migrate to HTTP/2, but it won't be able to if you're shipping client code that assumes spdy/3 without negotiation.

@swankjesse swankjesse closed this Jan 5, 2014

@takke

This comment has been minimized.

Show comment
Hide comment
@takke

takke Jan 5, 2014

I think so, too.

Thanks for your nice review.

takke commented Jan 5, 2014

I think so, too.

Thanks for your nice review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment