Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace statics with extension functions to create HttpUrls #5089

Merged
merged 1 commit into from May 22, 2019

Conversation

2 participants
@swankjesse
Copy link
Member

commented May 22, 2019

No description provided.

@@ -1130,8 +1130,7 @@ class HttpUrl internal constructor(
}

private fun removeAllCanonicalQueryParameters(canonicalName: String) {
var i = encodedQueryNamesAndValues!!.size - 2
while (i >= 0) {
for (i in encodedQueryNamesAndValues!!.size - 2 downTo 0 step 2) {

This comment has been minimized.

Copy link
@Egorand

Egorand May 22, 2019

Collaborator

Nice

@swankjesse swankjesse merged commit b21ed68 into master May 22, 2019

3 checks passed

ci/circleci: checkjdk8 Your tests passed on CircleCI!
Details
ci/circleci: testjdk8alpn Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@oldergod oldergod deleted the jwilson.0521.toHttpUrl branch May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.