Add limits to what length values DerReader supports #6164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cketti
commented
Jul 2, 2020
With this change DerReader doesn't support reading values with a length greater than Long.MAX_VALUE. That shouldn't be a problem in practice.
swankjesse
approved these changes
Jul 3, 2020
| } | ||
| } | ||
|
|
||
| @Test fun `decode length equal to Long MAX_VALUE`() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change
DerReaderdoesn't support reading values with a length greater thanLong.MAX_VALUE. That shouldn't be a problem in practice.