Getting the exact error message in Picasso Callback onError #617

Closed
timschambers opened this Issue Aug 14, 2014 · 5 comments

Projects

None yet

4 participants

@timschambers

Hi,

I have an app in production which uses Picasso to load a variety of image URLs.
Some of these URLs point to "invalid" images which cannot be rendered by Picasso. So far, I have handled these exceptions by indicating what the error was to the end-user.

My dilemma lies in that these "cannot render image" exceptions are all generic. Neverminding the problems I can predict in advance (i.e. check if the image URL has a valid MIME type) my app can't articulate the precise reason why an image failed to load. To date, this lack of specificity has confused my users over whether the problem is with my app or the server from which the images are being loaded.

Are there plans to percolate the rendering exception that Picasso encounters to the callback for Picasso.load.into?

Looking forward to hearing other's thoughts on this matter.

@dnkoutso
Collaborator

No reason why you cant expose this. I am not sure we will be adding a public way to access this.

Not until 2.4 or after perhaps.

@timschambers

No reason I can't expose this? As in there's a way I can get at the exact error message in Picasso?

If not, I suppose I'll either have to fork the existing repo or wait until it becomes priority for the project.

@vikasgulati

Hey @timschambers, Were you able to get a workaround for this? Thank!

Hey @dnkoutso, had the same doubt as @timschambers w.r.t "No reason why you cant expose this". Is there a way to get the exact error reason? Thanks!

@JakeWharton
Member

No. This is a breaking change. Don't expect it until 3.0.

@timschambers

Hi,

I made a change to the code that allowed the errors to get percolated up
the call chain. You can do something similar via downloading the source,
setting a breakpoint on the exception handler and then stepping
out-and-out.

I do not advise making the same changes, however, as, Jake points out,
they are not guaranteed to work version to version.

On Tue, Feb 17, 2015 at 2:28 PM, Jake Wharton notifications@github.com
wrote:

No. This is a breaking change. Don't expect it until 3.0.


Reply to this email directly or view it on GitHub
#617 (comment).

@dnkoutso dnkoutso added this to the Picasso Next milestone Feb 18, 2015
@JakeWharton JakeWharton closed this in #1569 Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment