Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent a SQL injection #76

Merged
merged 1 commit into from Mar 6, 2020

Conversation

danrice-square
Copy link
Collaborator

Fix a potential SQL injection in a table name parameter

Copy link

@bwester bwester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong with the changes here. It might be useful to create a test case with identifiers similar to foo`;bar to catch any subtle errors. This PR focuses on table names, but all identifiers could conceivably have the same quoting problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants