Fail the build on import cycles. #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I really dislike this limitation but protoc enforces it, and not enforcing it makes interop with protoc.
swankjesse
force-pushed
the
jwilson.0630.dag_nabbit
branch
from
0e69fae
to
025b9ce
Compare
oldergod
approved these changes
Jul 1, 2020
| } | ||
|
|
||
| @Test | ||
| fun threeFileImportCycle() { |
| package com.squareup.wire.schema.internal | ||
|
|
||
| /** | ||
| * Checks whether a graph is a directed acyclic graph using [Tarjan's algorithm][tarjan]. |
There was a problem hiding this comment.
I definitely needed a lot of time to get this right, including reading the code sample from Wikipedia repeatedly. I would fail an interview that asks me to produce this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really dislike this limitation but protoc enforces it, and not enforcing
it makes interop with protoc.