From 734d29eda195ae697ac4370e7a911d04aa4ebed6 Mon Sep 17 00:00:00 2001 From: Tyler Stromberg Date: Thu, 10 Sep 2020 13:20:25 -0700 Subject: [PATCH 1/2] Make RenderContext.render(workflow:key:outputMap:) internal --- Workflow/Sources/RenderContext.swift | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Workflow/Sources/RenderContext.swift b/Workflow/Sources/RenderContext.swift index 8f7695974..47860ddf1 100644 --- a/Workflow/Sources/RenderContext.swift +++ b/Workflow/Sources/RenderContext.swift @@ -63,8 +63,7 @@ public class RenderContext: RenderContextType { /// - Parameter key: A string that uniquely identifies this child. /// /// - Returns: The `Rendering` result of the child's `render` method. - @available(*, deprecated, message: "Use `rendered(in:outputMap:)` on Workflow itself.") // To remove this deprecation, mark this method `internal` - public func render(workflow: Child, key: String, outputMap: @escaping (Child.Output) -> Action) -> Child.Rendering where Child: Workflow, Action: WorkflowAction, WorkflowType == Action.WorkflowType { + func render(workflow: Child, key: String, outputMap: @escaping (Child.Output) -> Action) -> Child.Rendering where Child: Workflow, Action: WorkflowAction, WorkflowType == Action.WorkflowType { fatalError() } From 1739807cfdced7147c274a2e38ffd8727f8c075c Mon Sep 17 00:00:00 2001 From: Tyler Stromberg Date: Thu, 10 Sep 2020 14:34:45 -0700 Subject: [PATCH 2/2] Update migration guide --- MigrationGuide_v1.0.md | 1 + 1 file changed, 1 insertion(+) diff --git a/MigrationGuide_v1.0.md b/MigrationGuide_v1.0.md index a275a8d0b..a8810d690 100644 --- a/MigrationGuide_v1.0.md +++ b/MigrationGuide_v1.0.md @@ -13,6 +13,7 @@ ### Child `Workflow`s `Workflow.rendered(with:key:)` was deprecated in Workflow v1.0α and has been removed in the beta. See details in the alpha migration guide, [below](#render-child-workflow). +`RenderContext.render(workflow:key:outputMap:)` has been made `internal` instead of `public`. Child `Workflow`s should be rendered via `ChildWorkflow().rendered(in: context)` instead. ---