Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding ABI validation using japicmp. #502

Closed
wants to merge 1 commit into from

Conversation

@zach-klippenstein
Copy link
Collaborator

commented Jul 25, 2019

I added a module that just uses japicmp to perform binary diffing. Not ready to merge for a few reasons.

  • This plugin only gives pass/fail results + a diff report. Since we don't actually want to block backwards-incompatible changes, the pass/fail isn't useful.
  • Unlike the binary validator used by the kotlin standard and coroutines libraries, this tool does not produce a dump that can be diffed by git
    • So in order to view the changes we need to expose the diff report from the Travis build somehow.
    • We can only easily diff against the last-released version, which makes the output much less useful for individual builds.

While this tool can help us once we hit v1.0 and don't want to break binary compatibility, it is not useful for more informative reporting about how our ABI is changing from commit-to-commit. I would much rather use a tool like the one in kotlin's libraries, but that is just raw source they've copy/pasted around. Not convinced it's worth it at this time.

@zach-klippenstein zach-klippenstein added this to the kotlin post-v1.0 milestone Jul 25, 2019

@zach-klippenstein zach-klippenstein added this to In progress in Workflow (Kotlin) via automation Jul 25, 2019

@zach-klippenstein zach-klippenstein changed the title WIP Adding ABI validation using japicmp. [WIP] Adding ABI validation using japicmp. Jul 25, 2019

Workflow (Kotlin) automation moved this from In progress to Done Sep 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.