createChannel() can throw with the callback API

[sakai135]

In the callback API, the createChannel() can throw an error instead of returning the error in the callback.

var amqp = require('amqplib/callback_api');
amqp.connect('amqp://localhost?channelMax=1', function(err, conn) {
  conn.createChannel(function(err) {
    if (err) {
      return console.log(err);
    }
    console.log('callback created 1');
    conn.createChannel(function(err) {
      // does not get called
      if (err) {
        return console.log(err);
      }
      console.log('callback created 2');
    }); // this immediately throws
  });
});

callback created 1

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: No channels left to allocate
    at Connection.C.freshChannel

[squaremo]

Yes you are quite right. (And similarly with the promise API, if it doesn't reject the promise.)

[squaremo]

Fixed in 5770c35