New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equalent go benchmark #12

Merged
merged 1 commit into from Feb 2, 2017

Conversation

Projects
None yet
2 participants
@heppu
Copy link
Contributor

heppu commented Feb 1, 2017

Fixes for #11

@squeaky-pl

This comment has been minimized.

Copy link
Owner

squeaky-pl commented Feb 1, 2017

Hi, thanks for the PR. Have you managed to measure more or less what kind of speedup it makes over the previous version?

@heppu

This comment has been minimized.

Copy link
Contributor Author

heppu commented Feb 1, 2017

I haven't run benchmarks yet. Could you provide commands you used to run your benchmarks? Unrelated to performance, the go code in PR is little bit cleaner and easier to read so even though the performance wouldn't increase significantly. =)

Edit: Oh you had the wrk stuf in misc folder, my bad. I will run the test. =)

@squeaky-pl

This comment has been minimized.

Copy link
Owner

squeaky-pl commented Feb 1, 2017

Great. Note that I run wrk 10 times in a row with -t 1-c 100 -d 2 and pipeline.lua script and took a median

@heppu

This comment has been minimized.

Copy link
Contributor Author

heppu commented Feb 1, 2017

Ok I ran the benchmark on the go version is 18% faster that the current go version on my machine.

@squeaky-pl

This comment has been minimized.

Copy link
Owner

squeaky-pl commented Feb 1, 2017

waiting for go-fasthttp results and gonna put an errata in the article.

@heppu

This comment has been minimized.

Copy link
Contributor Author

heppu commented Feb 1, 2017

Oh sorry I forgot to set GOMAXPROCS=1. The increase was ~12% with that setup. I gotta say that that kind of takes away the advantage of Go but still is valid if you are planning to run http server on single thread instance :D

@squeaky-pl squeaky-pl merged commit b8c4dd7 into squeaky-pl:master Feb 2, 2017

@squeaky-pl squeaky-pl referenced this pull request Feb 2, 2017

Closed

Equalent go benchmark #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment