New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv back end detection does not work on non version numbered release #105

Closed
zyphrus opened this Issue Aug 30, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@zyphrus

zyphrus commented Aug 30, 2015

I have been using the mpv back end for a while and after an update to mpv, gmusicbrowser
does not show it as a valid back end anymore.

After some digging I found out that the version number string changed from
mpv 0.9.2 (C) 2000-2015 mpv/MPlayer/mplayer2 projects to mpv git-f1778d1 (C) 2000-2015 mpv/MPlayer/mplayer2 projects

As a temporary fix I added the following to my local copy

$ok = $output=~m/mpv\s*git/i ? 1 : $ok;

to gmusicbrowser_mpv.pm's check_version function which gets everything working again but is probably not the best solution.

gmusicbrowser version: v1.1.15
OS: Arch Linux

@squentin

This comment has been minimized.

Show comment
Hide comment
@squentin

squentin Aug 30, 2015

Owner

Thanks, I'll fix it

Owner

squentin commented Aug 30, 2015

Thanks, I'll fix it

@squentin squentin closed this in 91892d9 Sep 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment