Preserve orderBy and page on subqueries. #147

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants

justinp commented May 18, 2012

Max,

This is the followup to PR #146. I couldn't add more commits to that one because I used the SHA instead of a branch name.

I've added the unit tests you asked for.

Thanks,
-Justin

Justin Patte... added some commits May 16, 2012

Can you please pull this?

Also broken is that the 'isForUpdate' field is not preserved on AbstractQuery.copy

Contributor

davewhittaker commented Jan 7, 2013

@max-l @pbrant Any thoughts on this? It's got a test included, so if the rest of the suite passes it looks ok to me.

Contributor

pbrant commented Jan 7, 2013

Works for me. IIRC (but only vaguely I'm afraid) there are situations where the PG grammar won't always let you provide a limit/offset without putting parens around the query, but if something like that does come up it can be fixed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment