Skip to content

Fix memory leak when rejecting SNMP queries #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

flozilla
Copy link
Contributor

@flozilla flozilla commented Oct 23, 2018

SNMP queries denied by snmp_access rules and queries with certain
unsupported SNMPv2 commands were leaking a few hundred bytes each. Such
queries trigger "SNMP agent query DENIED from..." WARNINGs in cache.log.

@squid-prbot
Copy link
Collaborator

Can one of the admins verify this patch?

@rousskov rousskov changed the title Fix memory leak that occurs during the parsing of SNMP packets Fix memory leak when rejecting SNMP queries Oct 23, 2018
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding and fixing this bug!

I have adjusted the PR title and description (i.e. the future commit message) to focus on the admin-important details. Please check that I did not misrepresent anything.

We probably should not put the other details into the commit message.

@rousskov
Copy link
Contributor

OK to test

@yadij
Copy link
Contributor

yadij commented Oct 24, 2018

Fast tracking this merge manually.

@yadij yadij merged commit 644131f into squid-cache:master Oct 24, 2018
@yadij yadij added the M-merged https://github.com/measurement-factory/anubis#pull-request-labels label Oct 24, 2018
squidadm pushed a commit to squidadm/squid that referenced this pull request Oct 25, 2018
SNMP queries denied by snmp_access rules and queries with certain
unsupported SNMPv2 commands were leaking a few hundred bytes each. Such
queries trigger "SNMP agent query DENIED from..." WARNINGs in cache.log.
yadij pushed a commit that referenced this pull request Oct 26, 2018
SNMP queries denied by snmp_access rules and queries with certain
unsupported SNMPv2 commands were leaking a few hundred bytes each. Such
queries trigger "SNMP agent query DENIED from..." WARNINGs in cache.log.
squidadm pushed a commit to squidadm/squid that referenced this pull request Oct 27, 2018
SNMP queries denied by snmp_access rules and queries with certain
unsupported SNMPv2 commands were leaking a few hundred bytes each. Such
queries trigger "SNMP agent query DENIED from..." WARNINGs in cache.log.
yadij pushed a commit that referenced this pull request Oct 27, 2018
SNMP queries denied by snmp_access rules and queries with certain
unsupported SNMPv2 commands were leaking a few hundred bytes each. Such
queries trigger "SNMP agent query DENIED from..." WARNINGs in cache.log.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants