New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent truncation for large origin-relative domains #427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please avoid code duplication.
- Please do not give the end user the ability to flood cache.log with useless level-1 messages. If you insist on logging something at level 1, then add a logging limit (e.g., increase the level after the first 10 level-1 messages).
- Please do not change
!strchr()"not there" mnemonic to a lot less intuitivestrchr() == 0. The latter comparison with zero is good for strcmp() but not for strchr().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have one semi-important correction. The rest is polishing.
... and refactor slightly to prevent underflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing my change requests.
N.B. Please avoid resolving the change requests that you have not requested, regardless of whether you think they are resolved.
The domain in a URL must obey hostname length restrictions after append_domain is applied, not just MAX_URL for the normalized absolute-URL.
The domain in a URL must obey hostname length restrictions after append_domain is applied, not just MAX_URL for the normalized absolute-URL.
The domain in a URL must obey hostname length restrictions after append_domain is applied, not just MAX_URL for the normalized absolute-URL.
The domain in a URL must obey hostname length restrictions after append_domain is applied, not just MAX_URL for the normalized absolute-URL.
The domain in a URL must obey hostname length restrictions after append_domain is applied, not just MAX_URL for the normalized absolute-URL.
The domain in a URL must obey hostname length restrictions after append_domain is applied, not just MAX_URL for the normalized absolute-URL.
The domain in a URL must obey hostname length restrictions after
append_domain is applied, not just MAX_URL for the normalized
absolute-URL.