Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cachemgr.cgi: Add validation for hostname parameter #504

Closed
wants to merge 14 commits into from
Closed

cachemgr.cgi: Add validation for hostname parameter #504

wants to merge 14 commits into from

Conversation

aaron-costello
Copy link
Contributor

Prevention of HTML/invalid chars in host param

@squid-prbot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Contributor

@yadij yadij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just style polish. LGTM

tools/cachemgr.cc Outdated Show resolved Hide resolved
tools/cachemgr.cc Outdated Show resolved Hide resolved
tools/cachemgr.cc Outdated Show resolved Hide resolved
tools/cachemgr.cc Outdated Show resolved Hide resolved
tools/cachemgr.cc Outdated Show resolved Hide resolved
tools/cachemgr.cc Outdated Show resolved Hide resolved
tools/cachemgr.cc Outdated Show resolved Hide resolved
tools/cachemgr.cc Outdated Show resolved Hide resolved
tools/cachemgr.cc Outdated Show resolved Hide resolved
tools/Makefile.am Show resolved Hide resolved
@yadij
Copy link
Contributor

yadij commented Nov 3, 2019

OK to test

@yadij yadij changed the title Added validation for hostname parameter cachemgr.cgi: Add validation for hostname parameter Nov 3, 2019
aaron-costello and others added 10 commits November 3, 2019 12:11
Co-Authored-By: Amos Jeffries <yadij@users.noreply.github.com>
Co-Authored-By: Amos Jeffries <yadij@users.noreply.github.com>
Co-Authored-By: Amos Jeffries <yadij@users.noreply.github.com>
Co-Authored-By: Amos Jeffries <yadij@users.noreply.github.com>
Co-Authored-By: Amos Jeffries <yadij@users.noreply.github.com>
Co-Authored-By: Amos Jeffries <yadij@users.noreply.github.com>
Co-Authored-By: Amos Jeffries <yadij@users.noreply.github.com>
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changes of the should-not-exist code without review to help Amos with his v4 release schedule.

@rousskov rousskov added the M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels label Nov 4, 2019
squid-anubis pushed a commit that referenced this pull request Nov 4, 2019
Prevention of HTML/invalid chars in host param
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Nov 4, 2019
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Nov 5, 2019
squidadm pushed a commit to squidadm/squid that referenced this pull request Nov 5, 2019
Prevention of HTML/invalid chars in host param
yadij pushed a commit that referenced this pull request Nov 5, 2019
Prevention of HTML/invalid chars in host param
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
5 participants