Added tests to CI

squidfunk · Mar 2, 2020 · 6c01378 · 6c01378
1 parent a461ee8
commit 6c01378
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 39 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -54,6 +54,9 @@ jobs:
       - run: npm run lint
       - run: npm run build
       - run: npm run test
+        env:
+          SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }}
+          SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }}
 
   # Publish Python package and Docker image
   publish:

diff --git a/package.json b/package.json
@@ -31,6 +31,7 @@
     "build": "make build",
     "clean": "make clean",
     "lint": "make lint",
+    "test": "make test",
     "watch": "make watch"
   },
   "devDependencies": {

diff --git a/src/worker/index.ts b/src/worker/index.ts
@@ -123,9 +123,11 @@ export class IFrameWorker implements Worker {
    * Immediately terminate the worker
    */
   public terminate() {
+    document.body.removeChild(this.iframe)
+
+    /* Unregister internal listeners */
     window.removeEventListener("message", this.handleMessage)
     window.onerror = null
-    this.iframe.remove()
   }
 
   /**

diff --git a/tests/config/browsers/unit.json b/tests/config/browsers/unit.json
@@ -26,40 +26,5 @@
     "version": "latest-1",
     "platform": "Windows 7",
     "screenResolution": "1280x1024"
-  },
-  "edge15": {
-    "base": "SauceLabs",
-    "browserName": "MicrosoftEdge",
-    "version": "15",
-    "platform": "Windows 10",
-    "screenResolution": "1280x1024"
-  },
-  "edge14": {
-    "base": "SauceLabs",
-    "browserName": "MicrosoftEdge",
-    "version": "14",
-    "platform": "Windows 10",
-    "screenResolution": "1280x1024"
-  },
-  "edge13": {
-    "base": "SauceLabs",
-    "browserName": "MicrosoftEdge",
-    "version": "13",
-    "platform": "Windows 10",
-    "screenResolution": "1280x1024"
-  },
-  "ie11": {
-    "base": "SauceLabs",
-    "browserName": "internet explorer",
-    "version": "11",
-    "platform": "Windows 10",
-    "screenResolution": "1280x1024"
-  },
-  "ie10": {
-    "base": "SauceLabs",
-    "browserName": "internet explorer",
-    "version": "10",
-    "platform": "Windows 8",
-    "screenResolution": "1280x1024"
   }
 }
diff --git a/tests/workers/error.js b/tests/workers/error.js
@@ -24,6 +24,6 @@
  * Worker
  * ------------------------------------------------------------------------- */
 
-addEventListener("message", () => {
+addEventListener("message", function() {
   throw new Error("Error in worker")
 })
diff --git a/tests/workers/message.js b/tests/workers/message.js
@@ -24,6 +24,6 @@
  * Worker
  * ------------------------------------------------------------------------- */
 
-addEventListener("message", () => {
+addEventListener("message", function() {
   postMessage("pong")
 })
diff --git a/tests/workers/scripts.js b/tests/workers/scripts.js
@@ -29,6 +29,6 @@ importScripts(
   "base/workers/script-import-b.js"
 )
 
-addEventListener("message", () => {
+addEventListener("message", function() {
   postMessage(a + b)
 })