Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Padding/Margin of dictionary elements #173
It seems dictionary elements don't have any padding or margin at their bottom when in normal vieweing mode, but when in mobile view, we get good padding.
Normal wide viewing mode:
Mobile viewing (narrow mode).
In normal viewing mode, dictionaries will have good looking margin and/or padding at bottom.
During normal viewing mode dictionaries have no padding and/or margin at the bottom.
Steps to reproduce the bug
markdown_extensions: - markdown.extensions.toc: slugify: !!python/name:pymdownx.slugs.uslugify permalink: - markdown.extensions.admonition: - markdown.extensions.smarty: smart_quotes: false - pymdownx.betterem: - markdown.extensions.attr_list: - markdown.extensions.def_list: - markdown.extensions.tables: - markdown.extensions.abbr: - pymdownx.extrarawhtml: - pymdownx.superfences: css_class: codehilite - pymdownx.highlight: extend_pygments_lang: - name: php-inline lang: php options: startinline: true - pymdownx.inlinehilite: css_class: codehilite - pymdownx.magiclink: repo_url_shortener: true base_repo_url: https://github.com/facelessuser/pymdown-extensions - pymdownx.tilde: - pymdownx.caret: - pymdownx.smartsymbols: - pymdownx.emoji: emoji_generator: !!python/name:pymdownx.emoji.to_svg - pymdownx.escapeall: hardbreak: True nbsp: True - pymdownx.tasklist: custom_checkbox: true - pymdownx.progressbar: - pymdownx.arithmatex: - pymdownx.mark: - pymdownx.plainhtml: strip_attributes: '' - pymdownx.snippets: base_path: docs/snippets
Yeah. The key is to have
Here's a simple example. We will do two dictionaries, each with a list (there is a space after the colons).
When you inspect the HTML in your browser, the
First of all, thanks for the very detailed explanation! It's a pleasure to work with such a detailed bug report. The issue was fixed in commit 3e50c33.
The margin bug came from the reset of the bottom margin of the last element within
I furthermore added some styles for definition lists - left them out originally as I wanted to wait if someone even uses them. I aligned the lists with the normal lists and added a section on the specimen page:
As I just released 1.0.4 three days ago and 1.0.5 yesterday fixing some nasty bugs, I will wait for some more stuff to accumulate before releasing it because I consider this a rather minor issue, hope that's okay for you.