New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suboptimal syntax highlighting for PHP #30

Closed
bobmulder opened this Issue May 11, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@bobmulder

Hey guys,

I love the theme, but I hate it that hightlighting isn't done by default, and the mentioned extension doesn't work as wel...

I get the following (for PHP):
image
* Only set and object?*

Please can we add support to this?

@d0ugal

This comment has been minimized.

Show comment
Hide comment
@d0ugal

d0ugal May 11, 2016

Did you specify the language as PHP?

d0ugal commented May 11, 2016

Did you specify the language as PHP?

@squidfunk

This comment has been minimized.

Show comment
Hide comment
@squidfunk

squidfunk May 11, 2016

Owner

Highlighting is done using pygments and there may be classes that are undefined. I will provide a fix asap.

Owner

squidfunk commented May 11, 2016

Highlighting is done using pygments and there may be classes that are undefined. I will provide a fix asap.

@squidfunk

This comment has been minimized.

Show comment
Hide comment
@squidfunk

squidfunk May 11, 2016

Owner

Can you provide the corresponding markdown? For me it seems pygments is completely broken for PHP, as I only get spans with the class x.

Owner

squidfunk commented May 11, 2016

Can you provide the corresponding markdown? For me it seems pygments is completely broken for PHP, as I only get spans with the class x.

@d0ugal

This comment has been minimized.

Show comment
Hide comment
@d0ugal

d0ugal May 11, 2016

Try starting the code sample with <?php. For example:

```php
<?php
public function registerContainerDefinitions(ContainerBuilder $container)
{
    // ...
}
```

d0ugal commented May 11, 2016

Try starting the code sample with <?php. For example:

```php
<?php
public function registerContainerDefinitions(ContainerBuilder $container)
{
    // ...
}
```
@squidfunk

This comment has been minimized.

Show comment
Hide comment
@squidfunk

squidfunk May 11, 2016

Owner

Forgot about that, thanks @d0ugal

Owner

squidfunk commented May 11, 2016

Forgot about that, thanks @d0ugal

@squidfunk squidfunk added this to the 0.2.3 milestone May 11, 2016

@squidfunk squidfunk added the bug label May 11, 2016

@squidfunk squidfunk self-assigned this May 11, 2016

@squidfunk squidfunk changed the title from No highlighting? to Suboptimal syntax highlighting for PHP May 11, 2016

@squidfunk squidfunk closed this in 016b1a2 May 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment