Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git fatal checkout on Windows #316

Closed
facelessuser opened this issue May 9, 2017 · 2 comments
Closed

Git fatal checkout on Windows #316

facelessuser opened this issue May 9, 2017 · 2 comments
Assignees
Labels
bug

Comments

@facelessuser
Copy link
Contributor

@facelessuser facelessuser commented May 9, 2017

Description

Was trying to checkout my fork for a pull request on my Windows system and got:

mkdocs-material.git
Cloning into 'mkdocs-material'...
remote: Counting objects: 8420, done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 8420 (delta 3), reused 0 (delta 0), pack-reused 8414
Receiving objects: 100% (8420/8420), 6.88 MiB | 0 bytes/s, done.
Resolving deltas: 100% (4785/4785), done.
fatal: cannot create directory at 'tests/visual/baseline/ci/md-nav--primary/md-n
av__item--nested/md-nav__link/:focus': Invalid argument
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'

Windows does not allow : in folder names. So this limits contributions from people on windows. Luckily I usually work on Mac, but these folders should probably get renamed.

Expected behavior

git clone to work on Windows.

Actual behavior

Git clone fails (or better phrased, the checkout part fails) on windows due to invalid Windows folder names.

Steps to reproduce the bug

  1. Git clone on Windows. Checkout will fail.

Package versions

  • Material: tip of master

System information

  • OS: Windows, and probably only windows.
@squidfunk
Copy link
Owner

@squidfunk squidfunk commented May 9, 2017

Ah thanks, that's bad. I will remove the visual regression test baseline anyways as I want to switch to something more robust.

@squidfunk squidfunk self-assigned this May 13, 2017
@squidfunk squidfunk added the bug label May 13, 2017
@squidfunk
Copy link
Owner

@squidfunk squidfunk commented May 15, 2017

Fixed in #325.

@squidfunk squidfunk closed this May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.