New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search shortcut breaks forms #398

Closed
markeganfuller opened this Issue Jul 18, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@markeganfuller

markeganfuller commented Jul 18, 2017

Search shortcut breaks forms

We have a number of forms in our mkdocs site which are broken by the search shortcut (s / f).

Expected behavior

Search only opens when not focused on a form element.

Actual behavior

When typing in a form field (e.g. input / text area) an s or f will open the search.

Steps to reproduce the bug

  1. Add the following to a test page
<form>
<input></input>
<textarea></textarea>                                                                                                
</form>
  1. Attempt to write sausages in the input / text area

Package versions

  • Python: Python 2.7.13
  • MkDocs: 0.16.3
  • Material: 1.7.4

Potential fix

I think the code to fix this would be a change to: https://github.com/squidfunk/mkdocs-material/blob/master/src/assets/javascripts/application.js#L340

Something like this to check if the current focused element is part of a form:

if (document.activeElement.form === undefined) {
  if (ev.keyCode === 70 || ev.keyCode === 83) {
    query.focus()
    ev.preventDefault()
  }
}

That seems to work in testing but doesn't pass the 'flow' check and I'm not quite familiar enough with js to quickly make this work.

@squidfunk

This comment has been minimized.

Show comment
Hide comment
@squidfunk

squidfunk Jul 18, 2017

Owner

That's indeed a bug, thanks for reporting and the potential fix!

Owner

squidfunk commented Jul 18, 2017

That's indeed a bug, thanks for reporting and the potential fix!

@squidfunk

This comment has been minimized.

Show comment
Hide comment
@squidfunk

squidfunk Jul 25, 2017

Owner

Fixed in #407, will be released shortly with 1.7.5.

Owner

squidfunk commented Jul 25, 2017

Fixed in #407, will be released shortly with 1.7.5.

@squidfunk squidfunk closed this Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment