Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on Logo/Title without Github-Repository: "None" #4

Closed
sebastian-marinescu opened this issue Feb 21, 2016 · 2 comments
Closed

Click on Logo/Title without Github-Repository: "None" #4

sebastian-marinescu opened this issue Feb 21, 2016 · 2 comments
Assignees
Labels
bug

Comments

@sebastian-marinescu
Copy link
Contributor

@sebastian-marinescu sebastian-marinescu commented Feb 21, 2016

Hi @squidfunk, first of all: Very good job! I like your theme very much.

I'm writing a manual right now and tried mkDocs with your theme.
It works good, but I had some unexpected behavior:

When not provided with a repo_url, the logo/title are linked to literally: "None".
My expectation is, that it links to the root: "/".

What do you think about this?
Kind regards, Sebastian

@squidfunk
Copy link
Owner

@squidfunk squidfunk commented Feb 21, 2016

Good idea, haven't thought about the non-repo case yet, as I only use it for my coding projects ;-) I think from a semantic aspect your idea is great, so I will provide a fix for master and pack it into 0.1.3.

@squidfunk squidfunk added the bug label Feb 21, 2016
@squidfunk squidfunk self-assigned this Feb 21, 2016
@squidfunk squidfunk closed this in ba72ddb Feb 21, 2016
@sebastian-marinescu
Copy link
Contributor Author

@sebastian-marinescu sebastian-marinescu commented Feb 21, 2016

Very nice, you also fixed the JS-error by this 👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.