Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github repo stars and forks component counters doesn't shows up #421

Closed
elvismdev opened this issue Aug 1, 2017 · 14 comments
Closed

Github repo stars and forks component counters doesn't shows up #421

elvismdev opened this issue Aug 1, 2017 · 14 comments
Assignees
Labels

Comments

@elvismdev
Copy link

@elvismdev elvismdev commented Aug 1, 2017

Description

The Github repo stars and forks counters doesn't shows up.

Expected behavior

I expect them to show up like in the demo and documentation page http://squidfunk.github.io/mkdocs-material/

image

Actual behavior

Instead it comes up with the "vendor/package" slug name only, without nothing under it. Also no JS errors in the console or in the mkdocs serve log in my console once I run it to develop from http://127.0.0.1:8000/

image

If I "inspect elements" and compare with the markup from the demo, I see this part is completely missing on my end.

<ul class="md-source__facts"
    <li class="md-source__fact">621 Stars</li>
    <li class="md-source__fact">170 Forks</li>
</ul>

Steps to reproduce the bug

  1. Install the latest version of Material with pip: pip install mkdocs-material
  2. Add the following line to mkdocs.yml: theme: 'material'
  3. Run the built-in dev-server: mkdocs serve
  4. Open up http://127.0.0.1:8000/ in the browser

Package versions

  • Python: Python 2.7.10
  • MkDocs: mkdocs, version 0.16.3
  • Material: Version: 1.7.5

Project configuration

site_name: Starter WordPress Theme
repo_url: https://github.com/vendorname/starter-wp-theme
repo_name: vendorname/starter-wp-theme
edit_uri: edit/master/docs
site_author: Elvis Morales
site_description: A WordPress starter theme.
theme: material
pages:
  - About: index.md
  - Getting Started: getting-started.md
  - Helper Functions: helper-functions.md


# Copyright
copyright: 'Copyright &copy; 2016 - 2017 Elvis Morales'


# Options
extra:
  feature:
    tabs: false
  palette:
    primary: red
    accent: red
  social:
    - type: globe
      link: https://companyname.com
    - type: github-alt
      link: https://github.com/companyname
    - type: twitter
      link: https://twitter.com/companyname
    - type: linkedin
      link: https://linkedin.com/companyname

markdown_extensions:
  - toc:
      permalink: true```

### System information

* OS: macOS Sierra 10.12.5
* Browser: Google Chrome Version 59.0.3071.115
@squidfunk
Copy link
Owner

@squidfunk squidfunk commented Aug 2, 2017

Is there some error to see in the network inspector? It seems that the request failed.

@squidfunk
Copy link
Owner

@squidfunk squidfunk commented Aug 2, 2017

Also try to delete the cooke which caches results and is called: ${HASH}.cache-sources

@elvismdev
Copy link
Author

@elvismdev elvismdev commented Aug 2, 2017

@squidfunk I tried deleting the cookie ${HASH}.cache-source but same result. Also any error comes up in the network inspector, all requests are 200 OK.

image

This is the repo I'm putting this documentation together: https://github.com/forumone/gesso-wp

Any other thoughts why stars and forks numbers are failing to show up?

@squidfunk
Copy link
Owner

@squidfunk squidfunk commented Aug 3, 2017

Nope, I cannot reproduce this, it's perfectly working.

@squidfunk
Copy link
Owner

@squidfunk squidfunk commented Aug 3, 2017

I managed to reproduce it. There a reonly 30 repos returned from the GitHub API, so we need to paginate if the repo is not found and there are more than 30.

@squidfunk squidfunk self-assigned this Aug 3, 2017
@squidfunk squidfunk added the bug label Aug 3, 2017
@elvismdev
Copy link
Author

@elvismdev elvismdev commented Aug 3, 2017

Yes that should be it, seems like for user accounts/organizations that has more than 30 repos, if not found the repository on the first response to api.github.com/users/orgname, then it should paginate for more until it find's it.

Glad you were able to reproduce it!

@squidfunk
Copy link
Owner

@squidfunk squidfunk commented Aug 7, 2017

Rather tricky figuring out how to do an endless Promise chain, but managed to implement it in #429. Will release 1.8.1 shortly.

@squidfunk
Copy link
Owner

@squidfunk squidfunk commented Aug 7, 2017

Just released 1.8.1, please re-open in case of problems.

@squidfunk squidfunk closed this Aug 7, 2017
@yks0000
Copy link

@yks0000 yks0000 commented May 9, 2018

I am seeing this issue again in version 2.7.3.

@squidfunk
Copy link
Owner

@squidfunk squidfunk commented May 9, 2018

Please re-open the issue and provide more information when you're seeing this. Ideally a reproducible scenario. Thanks!

@dgomesbr
Copy link

@dgomesbr dgomesbr commented May 11, 2020

This is something that just happened to my repo, you can get rate limited by GH

@squidfunk
Copy link
Owner

@squidfunk squidfunk commented May 11, 2020

GitHub requests were refactored in v5, so running into the rate limit should be rather unlikely.

@dgomesbr
Copy link

@dgomesbr dgomesbr commented May 11, 2020

Thank you!

@dgomesbr
Copy link

@dgomesbr dgomesbr commented May 12, 2020

Just to leave it here, my issue was that in a VPN most of my team was using the same IP address, so we reached the limit quickly. Loading the portal without VPN was working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants