Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation sections are rendered as links #4358

Closed
5 tasks done
lastsecondsave opened this issue Sep 14, 2022 · 5 comments
Closed
5 tasks done

Navigation sections are rendered as links #4358

lastsecondsave opened this issue Sep 14, 2022 · 5 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@lastsecondsave
Copy link

Contribution guidelines

I've found a bug and checked that ...

  • ... the problem doesn't occur with the mkdocs or readthedocs themes
  • ... the problem persists when all overrides are removed, i.e. custom_dir, extra_javascript and extra_css
  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

In the version 8.5.0 a first navigation section is rendered as a link:

image

Expected behaviour

As it's just a title nothing should happen when you hover over it.

Actual behaviour

When you hover over it, the section acts as a link, although it's not clickable. Other sections renders fine.

Steps to reproduce

Enable features mentioned in the configuration below.

Package versions

  • Python: 3.10.4
  • MkDocs: 1.3.0
  • Material: 8.5.0

Configuration

theme:
  name: material
  features:
    - navigation.sections
    - navigation.tabs
    - toc.integrate

System information

  • Browser: Firefox, Chrome
@squidfunk
Copy link
Owner

Thanks for reporting. Does this also happen with 8.4.4?

@squidfunk squidfunk added the needs investigation Issue must be investigated by the maintainers label Sep 14, 2022
@lastsecondsave
Copy link
Author

No, on 8.4.4 everything is good.

@squidfunk
Copy link
Owner

Okay, it's a regression then.

@squidfunk squidfunk added bug Issue reports a bug and removed needs investigation Issue must be investigated by the maintainers labels Sep 14, 2022
@squidfunk
Copy link
Owner

Fixed in f30775f. It was indeed a regression related to the merge, as the navigation code is slightly different in Insiders due to the support for navigation icons, status and pruning.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Sep 18, 2022
@squidfunk
Copy link
Owner

Released as part of 8.5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants