New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Safari on how menu is only sized to main content #468

Closed
alkemann opened this Issue Sep 18, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@alkemann

alkemann commented Sep 18, 2017

Description

See comparison screenshots between Safari and Firefox bellow. Desired outcome is that the sidebar get maximum height.

Expected behavior

Firefox 55.0.3 ("good behaviour"):
30209280-8bcf16c4-9497-11e7-9c6f-359b0c120f31

Actual behavior

Safari 10.1.2 ( "buggy behaviour" ):
30209255-7b7f1b84-9497-11e7-9cd4-94bad37181c7

Steps to reproduce the bug

  1. Look at a page with short content page while having a sidemeu with many options.

Package versions

  • Python: version 2.7.13
  • Mkdocs: version 0.16.3
  • Material: Version: 1.6.3

Project configuration

site_name: Documentation
theme: material
extra_css:
  - custom.css
extra:
  logo: "cc-logo.png"
markdown_extensions:
  - admonition
  - codehilite(guess_lang=false, linenums=true)
  - toc(permalink=true)

System information

  • Browser: Safari
@squidfunk

This comment has been minimized.

Show comment
Hide comment
@squidfunk

squidfunk Sep 19, 2017

Owner

Can you update to 1.10.1 and check if the error still persists?

Owner

squidfunk commented Sep 19, 2017

Can you update to 1.10.1 and check if the error still persists?

@squidfunk

This comment has been minimized.

Show comment
Hide comment
@squidfunk

squidfunk Sep 19, 2017

Owner

Also, try removing your custom CSS as it might cause the behavior.

Owner

squidfunk commented Sep 19, 2017

Also, try removing your custom CSS as it might cause the behavior.

@squidfunk squidfunk closed this Sep 19, 2017

@squidfunk squidfunk reopened this Sep 19, 2017

@squidfunk squidfunk added the bug label Sep 19, 2017

@squidfunk

This comment has been minimized.

Show comment
Hide comment
@squidfunk

squidfunk Sep 19, 2017

Owner

Confirmed, Safari doesn't correctly apply min-height.

Owner

squidfunk commented Sep 19, 2017

Confirmed, Safari doesn't correctly apply min-height.

@alkemann

This comment has been minimized.

Show comment
Hide comment
@alkemann

alkemann Sep 26, 2017

Maybe this?

.md-container>.md-main>.md-main__inner {
    height: inherit;
    position: relative;
}

alkemann commented Sep 26, 2017

Maybe this?

.md-container>.md-main>.md-main__inner {
    height: inherit;
    position: relative;
}
@squidfunk

This comment has been minimized.

Show comment
Hide comment
@squidfunk

squidfunk Oct 6, 2017

Owner

Had to change min-height to height.

Owner

squidfunk commented Oct 6, 2017

Had to change min-height to height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment