Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vertical scrollbar on short pages #495

Closed
AndreWin opened this issue Oct 14, 2017 · 6 comments
Closed

Remove vertical scrollbar on short pages #495

AndreWin opened this issue Oct 14, 2017 · 6 comments

Comments

@AndreWin
Copy link

@AndreWin AndreWin commented Oct 14, 2017

Hello.

There are vertical scrollbar on the right when I see these pages.

I found that height(.md-container) + 1 px = height(.md-container .md-main) +
height(.md-container .md-footer).

How can I fix this?

Best regards,
Andrey.

@AndreWin
Copy link
Author

@AndreWin AndreWin commented Oct 14, 2017

When I make height of .md-container less on 1 px, this hide scrollbar.

@AndreWin
Copy link
Author

@AndreWin AndreWin commented Oct 14, 2017

The only fix I found: .md-container {height: 99.9%}.

@squidfunk
Copy link
Owner

@squidfunk squidfunk commented Oct 15, 2017

The pixel is added to induce margin collapse. It's a compromise, see:

https://github.com/squidfunk/mkdocs-material/blob/master/src/assets/stylesheets/layout/_base.scss#L117-L120

I'm searching for another solution, but haven't found one so far.

@AndreWin
Copy link
Author

@AndreWin AndreWin commented Oct 15, 2017

Thank you very much for this fix, @squidfunk!

@squidfunk squidfunk changed the title Vertical scrollbar Remove vertical scrollbar on short pages Oct 16, 2017
@squidfunk
Copy link
Owner

@squidfunk squidfunk commented Oct 18, 2017

Fixed in #501

@squidfunk
Copy link
Owner

@squidfunk squidfunk commented Oct 18, 2017

Released with 1.10.4

@squidfunk squidfunk closed this Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants