New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrent offset after jumping to footnote in Firefox #586

Closed
max-ci opened this Issue Nov 13, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@max-ci

max-ci commented Nov 13, 2017

Description

Incorrent offset after jumping to footnote in Firefox (it doesn't take into account header height like in Chrome)

Expected behavior

Correct offset

Actual behavior

Incorrect offset in Firefox

Steps to reproduce the bug

  1. Open Firefox
  2. Go to https://squidfunk.github.io/mkdocs-material/extensions/footnotes/
  3. Click on backref

Package versions

  • MkDocs: 2.0.4
  • Material: 0.17.1

Project configuration

Irrelevant

System information

  • OS: OSX/Windows
  • Browser: Firefox 56.0.2 (OSX), Firefox 52.0.1 (Windows)

Works good on Chrome/Safari/Opera

@squidfunk squidfunk added the bug label Nov 14, 2017

@squidfunk squidfunk self-assigned this Nov 14, 2017

@squidfunk

This comment has been minimized.

Show comment
Hide comment
@squidfunk

squidfunk Nov 22, 2017

Owner

Fixed in #609 - again. I also refactored the code a little. This is something that comes up every now and then and is attributed to the fact that the behavior of Chrome is totally different to that of Firefox. Oh I love browsers 💩

Owner

squidfunk commented Nov 22, 2017

Fixed in #609 - again. I also refactored the code a little. This is something that comes up every now and then and is attributed to the fact that the behavior of Chrome is totally different to that of Firefox. Oh I love browsers 💩

@max-ci

This comment has been minimized.

Show comment
Hide comment
@max-ci

max-ci Nov 22, 2017

Yeah, love them too, especially differences between these two browsers 💔

max-ci commented Nov 22, 2017

Yeah, love them too, especially differences between these two browsers 💔

@squidfunk

This comment has been minimized.

Show comment
Hide comment
@squidfunk

squidfunk Nov 22, 2017

Owner

Released as part of 2.2.0.

Owner

squidfunk commented Nov 22, 2017

Released as part of 2.2.0.

@squidfunk squidfunk closed this Nov 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment