Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lunr languages conflict #673

Closed
max-ci opened this issue Jan 21, 2018 · 2 comments
Closed

Lunr languages conflict #673

max-ci opened this issue Jan 21, 2018 · 2 comments
Assignees
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@max-ci
Copy link

max-ci commented Jan 21, 2018

Description

Material is trying to load files like lunr.pl.js or lunr.nl.js when setting language to pl or nl and these files don't exist (search is not working in that case).

Expected behavior

Load default lunr.js files for some languages or nothing (I don't know)

Actual behavior

404 errors.

Steps to reproduce the bug

  1. Change language to pl or nl.
  2. Check the console.

Package versions

  • Python: 2.7.12
  • MkDocs: 0.17.2
  • Material: 2.5.1
@squidfunk squidfunk added the bug Issue reports a bug label Jan 21, 2018
@squidfunk squidfunk self-assigned this Jan 21, 2018
@squidfunk
Copy link
Owner

squidfunk commented Jan 21, 2018

Issue was auto-closed, there's a fix in master. The search language is now set according to the language, means there is an explicit mapping in the localization files - should handle much more cases. Also the non-existent JS loading error should be fixed. Will make a release in the next days.

@squidfunk squidfunk reopened this Jan 21, 2018
@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Jan 21, 2018
@squidfunk
Copy link
Owner

Fixed and released as part of 2.5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants