New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active page highlight not working with default palette #696

Closed
ovasquez opened this Issue Feb 7, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@ovasquez
Contributor

ovasquez commented Feb 7, 2018

Description

The active page highlight color doesn't work when using the color by default by not declaring the palette configuration. You are required to declare the palette colors for active page to work.

Expected behavior

The active page highlight should work when not explicitly declaring the palette. It should use the colors by default.
image

Actual behavior

The active page highlight doesn't work when not explicitly declaring the palette.
image

Steps to reproduce the bug

  1. Create any MkDocs website using material theme
  2. Do not set the palette
  3. Run mkdocs serve and see the active link not being highlighted

Package versions

  • Python: Python 3.6.1
  • MkDocs: mkdocs, version 0.17.2
  • Material: Version: 2.6.0

Project configuration

Just remove the palette configuration from the mkdocs.yml

System information

  • OS: Windows 10
  • Browser: Chrome, Firefox, Edge

u2 pushed a commit to cryptape/cita that referenced this issue Feb 10, 2018

@squidfunk

This comment has been minimized.

Owner

squidfunk commented Feb 11, 2018

That is indeed a regression. Thanks for reporting, will provide a fix.

@squidfunk squidfunk self-assigned this Feb 11, 2018

@squidfunk squidfunk added the bug label Feb 11, 2018

@squidfunk

This comment has been minimized.

Owner

squidfunk commented Feb 11, 2018

Fixed in 94acf18, another regression, thanks for reporting. Really need to set up visual regression testing.

@squidfunk squidfunk closed this Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment