Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sidebar toggle doesn’t work properly on 12.9" iPad #762

Closed
walkccc opened this issue Apr 16, 2018 · 10 comments

Comments

@walkccc
Copy link

commented Apr 16, 2018

Description

The sidebar toggle cannot unfold on 12.9" iPad unless I long pressed it.

Expected behavior

The sidebar toggle can unfold properly like on a laptop or desktop when I press the menu directory.

Actual behavior

When I long pressed it, the sidebar doesn't unfold. If I long press it(try to make it accent), then press it, it squeezed together. Like this:

clrs

Steps to reproduce the bug

  1. [First step]
  2. [Second step]
  3. [and so on...]

Package versions

  • Python: python --version
  • MkDocs: mkdocs --version
  • Material: pip show mkdocs-material | grep -E ^Version

Project configuration

The contents of your mkdocs.yml

System information

  • OS: iOS 11.2.6
  • Browser: Safari/Chrome

My iPad is 12.9 inches.

@walkccc walkccc changed the title The sidebar toggle doesn’t work on an iPad The sidebar toggle doesn’t work on 12.9" iPad Apr 16, 2018

@walkccc walkccc changed the title The sidebar toggle doesn’t work on 12.9" iPad The sidebar toggle doesn’t work properly on 12.9" iPad Apr 16, 2018

@squidfunk

This comment has been minimized.

Copy link
Owner

commented Apr 16, 2018

I'm afraid I cannot really reproduce this error, because I don't have an iPad - can you try to isolate the problem and PR a fix?

@walkccc

This comment has been minimized.

Copy link
Author

commented Apr 16, 2018

I think this is because of the different behaviors of click and touchstart.
But I can't find where you control the sidebar expanding behavior.
Maybe changing some click to touchstart click and increasing something like this:

var clickEvent = (function() {
    if ('ontouchstart' in document.documentElement === true)
        return 'touchstart';
    else
        return 'click';
})();

will be okay.

It's my personal opinion. Not sure if this is correct.

@squidfunk squidfunk added the bug label Apr 19, 2018

@squidfunk

This comment has been minimized.

Copy link
Owner

commented Apr 19, 2018

Thanks for your feedback, I'll see what we can do about it.

@walkccc

This comment has been minimized.

Copy link
Author

commented Jun 5, 2018

Hey, is this in progress?
Thank you!

@squidfunk

This comment has been minimized.

Copy link
Owner

commented Jun 6, 2018

My time is very limited at the moment. I hope I can find some to address the open issues but I cannot say when, I'm sorry.

@szcf-weiya

This comment has been minimized.

Copy link

commented Sep 24, 2018

Same problem on iPad Pro 12.9.

@szcf-weiya szcf-weiya referenced this issue Dec 13, 2018
@squidfunk

This comment has been minimized.

Copy link
Owner

commented Feb 13, 2019

Should be fixed by 4ca20f1.

@szcf-weiya

This comment has been minimized.

Copy link

commented Feb 13, 2019

Thank you very much! Now it works pretty well!!

@squidfunk

This comment has been minimized.

Copy link
Owner

commented Feb 13, 2019

Great, thanks for testing. I will issue a release with the latest bugfixes.

@squidfunk

This comment has been minimized.

Copy link
Owner

commented Feb 13, 2019

Released as part of 4.0.1

@squidfunk squidfunk closed this Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.