Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EmojiOne URL to prevent a HTTP redirect #1330

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@coliff
Copy link
Contributor

coliff commented Nov 6, 2019

@facelessuser

This comment has been minimized.

Copy link
Contributor

facelessuser commented Nov 6, 2019

Yeah, they've changed, and their license for their emoji images is now even less friendly than it was with version 3 release. Pymdown Extensions still uses their short name index as the short name index license is under MIT, but it still references the old CDN for emoji images with their version 3 emoji. Version 2 probably had their most user friendly license though.

I most likely will switch over to the Twemoji emoji index in my docs which uses the friendly name index from JoyPixels, but uses Twitter's emoji images. You get SVG through Twemoji as well which is pretty cool and they are pretty up to date. I liked the look of EmojiOne images a bit more, but Twemoji images aren't bad though.

@squidfunk

This comment has been minimized.

Copy link
Owner

squidfunk commented Nov 6, 2019

@facelessuser why is the license less friendly now? What has changed? Should we update the docs to recommend Twemoji?

@facelessuser

This comment has been minimized.

Copy link
Contributor

facelessuser commented Nov 6, 2019

@squidfunk, you can check out their license stuff. I'm no lawyer or anything:

Maybe its fine, but it got real specific.

They are focusing harder on monetizing the work, maybe it is safe to still use, but I feel like you have to be more careful.

I wasn't sure, so while I still use the latest short name index, which can be freely used, I still link to the old v3 CDN.

Twemoji is just more friendly: https://github.com/twitter/twemoji#license.

Feel free to take a look and give me your opinion. I'd love to get a secondary opinion on JoyPixels current free tier.

@facelessuser

This comment has been minimized.

Copy link
Contributor

facelessuser commented Nov 6, 2019

Small correction, I point to the 4.5 CDN which was the last under EmojiOne.

@squidfunk

This comment has been minimized.

Copy link
Owner

squidfunk commented Nov 6, 2019

  • Free license includes low-res PNG files and emoji fonts.
  • Businesses can use our free emoji for testing purposes only.

Not cool. Many companies (businesses) use Material, though I don't know how many use Emojis. Nevertheless, I would second your idea of switching to an alternative. Happy to merge contributions to the docs with further directions.

@facelessuser

This comment has been minimized.

Copy link
Contributor

facelessuser commented Nov 6, 2019

Yup, that was my feeling as well. It is just too strict for my taste. I feel Twemoji fills the gap much better.

@facelessuser

This comment has been minimized.

Copy link
Contributor

facelessuser commented Nov 6, 2019

I may make Twemoji pymdown-extensions the default moving forward. I'm not sure if any style change is required on Material side for targeting emoji classes, but I'll look into it.

@squidfunk

This comment has been minimized.

Copy link
Owner

squidfunk commented Nov 6, 2019

Perfect. I'm merging this PR now. Let's tackle the switch to Twemoji in another PR.

@squidfunk squidfunk merged commit b96f71c into squidfunk:master Nov 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@facelessuser

This comment has been minimized.

Copy link
Contributor

facelessuser commented Nov 7, 2019

FYI, I can't even find the license anymore for emojione 3 and 4. I wanted to compare the license again to 2.2.7, the last truly free version of EmojiOne. Unfortunately, it is impossible to find those licenses prior to the 5.0 release.

I've decided to walk back EmojiOne support to 2.2.7, which honestly has a ton of emoji support, and the only version I'm 100% sure is safe to use. EmojiOne will be locked to 2.2.7 indefinitely moving forward.

My personal projects will be using Twemoji moving forward which has the latest Unicode 12.0, but I wont force it as the default yet.

I will release a new version of PyMdown Extensions which will be using this safer version of EmojiOne, and then make a PR here showing people how to use Twemoji for the latest Unicode 12 emoji.

@squidfunk

This comment has been minimized.

Copy link
Owner

squidfunk commented Nov 7, 2019

@facelessuser perfect, thanks for your help!

@coliff coliff deleted the coliff:patch-1 branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.